[ixpmanager] Order of customers' config in the RS configuration of the IXP manager

[Andreas Polyrakis]

Hi Barry,

On 15/12/2014 04:43 μμ, Barry O'Donovan wrote:
>
> Hi Andreas,
>
> First of all, apologies for the delay in replying. You've sent a few
> mails I've wanted to reply to - including to the Euro-IX Bird list - but
> I've just been swamped.
>
> Starting with the end of your email:
>
>> Before filing a feature request, I wonder how other IXP-manager users
>> handle this: Do you use a different procedure to update the route
>> servers? Do humans need to review the changes before getting applied
>> (or at least they get notified)? Do you solve the problem in a
>> different approach?
>
> At INEX we've been running route servers for >7 years and have been
> auto-generating them from the very beginning. We've never had any issues.
>
> Human review is not necessary nor do we /require/ emails of changes. 
> Our Quagga based route server is on our RANCID configuration 
> management system which does email us. Bird is not (but see below re 
> backups).
>
> All changes are deterministic (* - see below also!) - if we haven't 
> enabled / disabled / changed a vlan interface for the route server, 
> then the configuration doesn't change. It's also important to say that 
> there are never 'human' changes to the generated script. The 
> deterministic nature of the configuration is the basis for the 
> Travis-CI tests also (more below).
>
> Any changes in the configuration go via IXP Manager templates (with 
> testing including Travis CI tests for known good / expected against 
> generated). This is all documented in the wiki - http://git.io/Evv2MQ 
> and http://git.io/GrAnqg.
>
> That's not to say we have blind faith that every step of the process
> just works! I.e. there's no point reloading Bird of the API call results
> in an error.
>

Thank you for you detailed reply.

I only want to add that it was not IXP manager that we do not trust; it 
is our scripts (which have not yet been tested extensively). I did not 
know that your scripts were also available (although it now seems that 
Rowan has already explained that to me). We will most probably use 
yours, so manual review of the changes might not be necessary.


>
> I've just tested and pushed the following diff:
>
> --- a/application/Repositories/VlanInterface.php
> +++ b/application/Repositories/VlanInterface.php
> @@ -72,7 +72,7 @@ class VlanInterface extends EntityRepository
>                          AND " . Customer::DQL_CUST_TRAFFICING . "
>                          AND pi.status = :pistatus";
>
> -        $qstr .= " ORDER BY c.autsys ASC";
> +        $qstr .= " ORDER BY c.autsys ASC, vli.id ASC";
>
> This will ensure deterministic ordering in all cases.
>

Thank you about this, too!

BR,


-- 
-----------------------------------------------------------------------
Andreas Polyrakis - apolyr at noc.grnet.gr
GRNET NOC Technical Manager
Greek Research & Technology Network - http://www.grnet.gr
56, Mesogion Av., Ampelokipi, 11527 Athens, Greece
Mobile: +30 6972832445    Office: +30 2107474249   Fax: +30 2107474490
-----------------------------------------------------------------------