[ixpmanager] v4.9.3 to v5.3.0 experience

[Leon Meßner]

Dear All,

i'm a little late to the party but wanted to share the bumps i
experienced going to v5.3.0.

- Having configured trustedproxy[1] in v4.9.3 and trying to "php
  composer.phar install ... " i got:

"""
Generating autoload files                                   
> Illuminate\Foundation\ComposerScripts::postAutoloadDump
> @php artisan package:discover
>                                                          
                                                                           
In trustedproxy.php line 67: 
  Undefined class constant 'HEADER_CLIENT_IP'
"""

  removing config/trustedproxy.php made it update. Having regenerated
  that file afterwards i could go from v5.0.0 upwards without problems.

- The MRTG docs[2] point to a stale link for crontabs[3].
  ("From IXP Manager >= v5.0, the task scheduler handles...")

- Update instructions of v5.x.0 still include chmod of
  public/bower_components, bower.json and var which should/do not
  exist anymore if one followed the instructions. This is probably of
  minute interest.

- Adding a user to a member (=customer) via this users' edit screen
  (user/edit/USERID) gives a 500 Server Error.
  The little plus sign links to
          https://$URL/customer-to-user/add?id=user%40domain.tld
  ixpmanager/storage/logs/laravel.log says:

"""
[2019-11-01 12:51:48] production.ERROR: Too few arguments to function
IXP\Http\Controllers\User\CustomerToUserController::add(), 0 passed and exactly 1 expected {"userId":1,"exception":"[object] (Symfony\\Component\\Debug\\Exception\\FatalThrowableError(code: 0): Too few arguments to function IXP\\Http\\Controllers\\User\\CustomerToUserController::add(), 0 passed and exactly 1 expected at /srv/ixp
manager/app/Http/Controllers/User/CustomerToUserController.php:76)
                                                                                                                                [stacktrace]                                                                                                                                                                                            
#0 [internal function]:
IXP\\Http\\Controllers\\User\\CustomerToUserController->add()
#1 /srv/ixpmanager/vendor/laravel/framework/src/Illuminate/Routing/Controller.php(54): call_user_func_array(Array, Array)                                                                               
#2 ....
"""

All considering this was still a very smooth update. Thank you very
much.

With best Regards,
Leon

[1] https://docs.ixpmanager.org/install/runtime/#behind-a-https-proxy
[2]
https://docs.ixpmanager.org/grapher/mrtg/#inserting-traffic-data-into-the-database-reporting-emails
[3] https://docs.ixpmanager.org/features/crontabs.md